Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy a test file for use in overwrite testing #3922

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

dj-mcg
Copy link
Collaborator

@dj-mcg dj-mcg commented Sep 19, 2024

Modifying a test file that is used in multiple tests is causing issues in our test framework. This change splits the file that is overwritten during the testReferenceCommands test to avoid corrupting other tests that are trying to use the same test file

Modifying a test file that is used in multiple tests is causing issues
in our test framework. This change splits the file that is overwritten
during the testReferenceCommands test to avoid corrupting other tests
that are trying to use the same test file
@seando-adsk seando-adsk added the unit test Related to unit tests (both python or c++) label Sep 20, 2024
@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Sep 20, 2024

I see that this causes the 2022 Windows python3 build to fail, which is surprising. Also, I don't seem to have access to the individual logs - I only see a result logfile and a start logfile

@seando-adsk
Copy link
Collaborator

@dj-mcg The 2022 build failed because of an internal network glitch accessing git. Unrelated to your changes. Since the other 2022 builds passed, I'll mark merge this.

Sean

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Sep 20, 2024
@seando-adsk seando-adsk merged commit 565a97f into Autodesk:dev Sep 20, 2024
10 of 11 checks passed
@dj-mcg dj-mcg deleted the pr/Copy_Test_File branch September 20, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants